Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix samples briefly showing up as unprofiled on patient view tab #3036

Merged
merged 1 commit into from
Feb 7, 2020

Conversation

onursumer
Copy link
Member

@onursumer onursumer commented Feb 3, 2020

Fix cBioPortal/cbioportal/issues/7090. Wait for gene panel data to complete before rendering patient view

Checks

  • Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

src/pages/patientView/PatientViewPage.tsx Show resolved Hide resolved
@@ -1098,6 +1101,9 @@ export default class PatientViewPage extends React.Component<

{this.patientViewPageStore.studyIdToStudy
.isComplete &&
this.patientViewPageStore
.genePanelIdToEntrezGeneIds
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alisman alisman merged commit 9260441 into cBioPortal:master Feb 7, 2020
@alisman alisman deleted the patient-view-tumor-col-fix branch February 7, 2020 21:45
onursumer added a commit to onursumer/cbioportal-frontend that referenced this pull request Feb 10, 2020
Signed-off-by: Onur Sumer <[email protected]>
@inodb inodb changed the title Waiting for gene panel data to complete before rendering patient view tables Fix samples briefly showing up as unprofiled on patient view tab Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patient page mutation table: Samples show briefly as not profiled
3 participants